Repository navigation
docs(valuation): describe high/low as fair-value band bounds - #1338
Open
hogan-yuan wants to merge 1 commit into
Open
hogan-yuan wants to merge 1 commit into
hogan-yuan wants to merge 1 commit into
Conversation
The valuation APIs return high/low as the upper/lower bounds of the fair-value band, not the period max/min. Fix the field tables (en/zh-CN/zh-HK) and add a note to the CLI valuation page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valuationsfield table (en / zh-CN / zh-HK):high/loware the 5-year fair-value band's bounds, not the 5-year max/min.valuation_historyfield table (en): same fix.valuationpage (en / zh-CN / zh-HK): note under the example output.Why
Found by the Longbridge AI online check (T09): the model treated
lowas the period minimum. For 388.HK,GET /v1/quote/valuation?indicator=pe&range=1returnslow25.19 /high30.05, but the 1-year series bottoms at 23.29 and tops at 32.74 (73 points belowlow, 70 abovehigh)./v1/quote/valuation/detailbehaves the same way (5-yearlow27.3 vs series min 23.52). The upstreamdesc("低于合理区间") confirms these are fair-value band bounds; the fundamental team confirmed the semantics.Note: zh-CN / zh-HK
valuation_history.mdxuse a different response table withouthigh/low, so they are left as is.🤖 Generated with Claude Code